<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thank you very much, Edmund!</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I addressed your comments as in-line below in the PR #91. Please review and approve.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<a href="https://bitbucket.org/openid/connect/pull-requests/91" id="LPlnk200880">https://bitbucket.org/openid/connect/pull-requests/91</a><br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Kindest Regards.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Kristina</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="appendonsend"></div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Edmund Jay <ejay@mgi1.com><br>
<b>Sent:</b> Friday, December 10, 2021 12:42<br>
<b>To:</b> Torsten Lodderstedt <torsten@lodderstedt.net>; Kristina Yasuda <Kristina.Yasuda@microsoft.com>; openid-specs-ab@lists.openid.net <openid-specs-ab@lists.openid.net><br>
<b>Subject:</b> OIDC4VP review comments</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div>Hi Torsten, Kristina,</div>
<div><br>
</div>
<div>Here are some review comments for the OIDC4VP.<br>
</div>
<div>There's also a PR for some minor editorial fixes.</div>
<div><br>
</div>
<div><br>
</div>
<div>2.4<br>
Moreover, the user can identity, authenticate, and authorize even in situations with unstable or without internet connectivity.<br>
<br>
Do you mean identify? If so, what is being identified?<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(12, 100, 192);">-> I changed to "</span><span style="background-color: rgb(255, 255, 255); display: inline !important; color: rgb(12, 100, 192);">Moreover, the user identification, authentication, and authorization can be done even in
situations with unstable or no internet connectivity.</span><span style="color: rgb(12, 100, 192);">"</span></div>
<div><br>
5.1<br>
<br>
“The format element underneath the presentation_definition that “<br>
<br>
The format element is “in” the presentation_definition.<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(12, 100, 192);">-> edited</span></div>
<div><br>
7.1. RP Metadata<br>
The link to PE v2 still points to v1.<br>
Also does it mean that v2 formats property will be used?<br>
If not using v2, maybe we shouldn’t mention it at all?<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(12, 100, 192);">-> fixed. yes, currently the interoperability point is achieved by using PE v2. not v1. this might change in the future.</span></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(12, 100, 192);"><br>
</span></div>
<div>8.1<br>
<br>
RPs MUST send a `nonce` parameter complying with the security considerations given in [@!OpenID], section 15.5.2., with every Authentication Request as a basis for replay detection.<br>
<br>
</div>
<div>Put normative language in the main text, perhaps?<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<span style="color: rgb(12, 100, 192);">-> Moved to the Response section. it is a little bit unnatural, but I agree the normative language should be in the main text..</span></div>
<div><br>
</div>
</div>
</div>
</body>
</html>