[Openid-specs-ab] OIDC4VP review comments

[Kristina Yasuda]

Thank you very much, Edmund!
I addressed your comments as in-line below in the PR #91. Please review and approve.
https://bitbucket.org/openid/connect/pull-requests/91
Kindest Regards.
Kristina


________________________________
From: Edmund Jay <ejay at mgi1.com>
Sent: Friday, December 10, 2021 12:42
To: Torsten Lodderstedt <torsten at lodderstedt.net>; Kristina Yasuda <Kristina.Yasuda at microsoft.com>; openid-specs-ab at lists.openid.net <openid-specs-ab at lists.openid.net>
Subject: OIDC4VP review comments

Hi Torsten, Kristina,

Here are some review comments for the OIDC4VP.
There's also a PR for some minor editorial fixes.


2.4
Moreover, the user can identity, authenticate, and authorize even in situations with unstable or without internet connectivity.

Do you mean identify? If so, what is being identified?
-> I changed to "Moreover, the user identification, authentication, and authorization can be done even in situations with unstable or no internet connectivity."

5.1

“The format element underneath the presentation_definition that “

The format element is “in” the presentation_definition.
-> edited

7.1. RP Metadata
The link to PE v2 still points to v1.
Also does it mean that v2 formats  property will be used?
If not using v2, maybe we shouldn’t mention it at all?
-> fixed. yes, currently the interoperability point is achieved by using PE v2. not v1. this might change in the future.

8.1

RPs MUST send a `nonce` parameter complying with the security considerations given in [@!OpenID], section 15.5.2., with every Authentication Request as a basis for replay detection.

Put normative language in the main text, perhaps?

-> Moved to the Response section. it is a little bit unnatural, but I agree the normative language should be in the main text..

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openid.net/pipermail/openid-specs-ab/attachments/20211215/8b3ddc2a/attachment.html>