[Openid-specs-ab] [EXTERNAL] Re: Working group reviews of OIDC4VP spec due Friday

Sat Dec 11 01:34:50 UTC 2021

Thank you very much, David!
I created a PR #89 incorporating your feedback.
https://bitbucket.org/openid/connect/pull-requests/89/david-chadwick-comments-sent-by-email
For what concretely I included in the PR, please see comments inline below.

All, please note that the latest editor's draft after removing the option to embed a VP in the ID Token has been published at: https://openid.bitbucket.io/connect/openid-connect-4-verifiable-presentations-1_0.html<https://openid.bitbucket.io/connect/openid-connect-4-verifiable-presentations-1_0.html#name-metadata>

Kindest Regards,
Kristina

________________________________
From: Openid-specs-ab <openid-specs-ab-bounces at lists.openid.net> on behalf of David Chadwick via Openid-specs-ab <openid-specs-ab at lists.openid.net>
Sent: Friday, December 10, 2021 14:28
To: Mike Jones <Michael.Jones at microsoft.com>; Artifact Binding/Connect Working Group <openid-specs-ab at lists.openid.net>
Cc: David Chadwick <d.w.chadwick at verifiablecredentials.info>
Subject: Re: [Openid-specs-ab] [EXTERNAL] Re: Working group reviews of OIDC4VP spec due Friday

Hi Mike
Here are the Edits

Section 6 first sentence. Verifiable credential -> verifiable presentation
-> vp_formats currently define format only the  VP, so the current text is correct. We can extend it to define format of VCs, too. I made a text suggestion in the PR. please review.

4th para Note that above claim-> Note that the above claim
-> superceded by PR #79

Section 11. using claims parameter -> using the claims parameter
-> in the PR

Section 11.1 returned inside ID Token -> returned inside the ID Token
-> superceded by PR #79

of Self-Issued -> of the Self-Issued
-> superceded by PR #79

also contain verifiable_credentials -> also contain the verifiable_credentials
-> superceded by PR #79

Section 11.1.1.1 presentations containg a -> presentations containing a
-> in the PR

Section 11.1.2 that includes verifiable_presentations claim ->that includes a verifiable_presentations claim
-> superceded by PR #79

Section 11.3 returned inside ID Token -> returned inside the ID Token
-> superceded by PR #79

of Authorization Code flow. ID Token  -> of the Authorization Code flow. The ID Token
-> in the PR

Section 11.4 Below are the examples when verifiable  -> Below are examples when the verifiable
-> superceded by PR #79

as part of OpenID  -> as part of the OpenID
-> superceded by PR #79

UserInfo response -> The UserInfo response
-> superceded by PR #79

Kind regards
David

On 10/12/2021 21:26 a, Mike Jones wrote:

You can send editorial issues either as e-mail or as a pull request.  Be sure that you’re basing your comments on the editor’s drafts at https://openid.bitbucket.io/connect/<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenid.bitbucket.io%2Fconnect%2F&data=04%7C01%7CKristina.Yasuda%40microsoft.com%7C2d47f0e420ee43f225d608d9bc2c6b82%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637747722025647743%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=VHob9bxeuJp%2Bv5mXkVyGcIeJkNRd6RENtoI4dw%2BjmMc%3D&reserved=0> since many updates have already been using claims
parameter  made to both specs.

                                                       Thanks,

                                                       -- Mike

From: David Chadwick <d.w.chadwick at verifiablecredentials.info><mailto:d.w.chadwick at verifiablecredentials.info>
Sent: Wednesday, December 8, 2021 1:22 PM
To: Artifact Binding/Connect Working Group <openid-specs-ab at lists.openid.net><mailto:openid-specs-ab at lists.openid.net>
Cc: Mike Jones <Michael.Jones at microsoft.com><mailto:Michael.Jones at microsoft.com>
Subject: [EXTERNAL] Re: [Openid-specs-ab] Working group reviews of OIDC4VP spec due Friday

Hi Mike

I have done a review of OIDC4VP and the only technical issue I have has been recorded in Issue #1369

I also have a lot of grammatical changes to suggest. What is the best way to deal with these?

Kind regards

David

On 07/12/2021 06:18, Mike Jones via Openid-specs-ab wrote:

As decided during the 2-Dec-21 call, the working group is requested to review the OpenID Connect for Verifiable Presentations specification at https://openid.net/specs/openid-connect-4-verifiable-presentations-1_0.html<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fopenid.net%2Fspecs%2Fopenid-connect-4-verifiable-presentations-1_0.html&data=04%7C01%7CKristina.Yasuda%40microsoft.com%7C2d47f0e420ee43f225d608d9bc2c6b82%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637747722025647743%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=GHal%2Be0qu%2FdLe7j3ce9V5iDA38Yyy22oxdte3qjbItM%3D&reserved=0> and get review comments in by this Friday, December 10th in preparation for an OpenID Foundation-wide review of the specification as a proposed Implementer’s Draft.

                                                                     -- Mike

_______________________________________________

Openid-specs-ab mailing list

Openid-specs-ab at lists.openid.net<mailto:Openid-specs-ab at lists.openid.net>

http://lists.openid.net/mailman/listinfo/openid-specs-ab<https://nam06.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.openid.net%2Fmailman%2Flistinfo%2Fopenid-specs-ab&data=04%7C01%7CKristina.Yasuda%40microsoft.com%7C2d47f0e420ee43f225d608d9bc2c6b82%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637747722025697733%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=3B6h67sjP%2FzsF9lKRSea%2FbUFht2fpxwc%2BXXEiXwwstE%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openid.net/pipermail/openid-specs-ab/attachments/20211211/2e53cb63/attachment.html>