[Code] GitHub Pull Requests for php-openid

Wed Jul 28 16:26:11 UTC 2010

On Mon, Jul 26, 2010 at 3:45 PM, Nathan Hazout <nathan.h at makemeheal.com>wrote:

>  OK here are the first few comments I have:
>
> - The readme says "You can view the HTML library documentation in the doc/
> directory." What doc directory? Could not find any ...
> (see issue #16 on github)
>

When the libraries were hosted on openidenabled.com, JanRain used a release
script to actually build the release.  This include, among other things,
generating the docs.  When you check the code directly out of github, you
have to generate the docs yourself using phpdoc (http://www.phpdoc.org/).
Instructions on how to exactly do that is definitely something we need to
document.  In the meantime, you can use the wayback machine to get the last
packaged release that JanRain had (v2.1.1)[0], as well as the online
docs[1].  We also need to get back into the habit of doing these release
builds and putting them on the new downloads page[2].

[0]:
http://web.archive.org/web/20080822183555/http://openidenabled.com/files/php-openid/packages/php-openid-2.1.1.zip
[1]:
http://web.archive.org/web/20080822051327/openidenabled.com/files/php-openid/docs/2.1.1/
[2]: http://github.com/openid/php-openid/downloads

> - I just downloaded the code, opened the README which says to first try to
> run the 'examples/detect.php'.
> The page redirects me to detect.php?test_query=a%26b, but loads a blank
> page. 'display_errors' is ON.
> Shouldn't this page work no matter what, as it is supposed to show me
> what's missing?
> I'm running php 5.3 on a localhost.
> (issue #14)
>

more than likely, it's due to using php 5.3.  We haven't done the best job
of addresses warnings and errors that have surfaced with more recent
versions of PHP.

> - And then my main issue, I am looking for a documentation or tutorial that
> would help me make my website an OpenId provider, using my existing users
> (usernames and passwords are stored in a MySQL database).
>
>
> http://stackoverflow.com/questions/3208905/creating-a-openid-provider-in-php
>
>
There is also a sample OpenID server in the examples directory, however if
you're having problems with the detect script, than I full expect that you'd
have problems with the example server.  This is absolutely something that we
need to fix.  You could certainly still look at the example server code and
see how it works... it's pretty straightforward.

-will

> Best Regards,
> Nathan Hazout
> Makemeheal.com
>
> 818-883-3300 (ext 108)
> 20750 Ventura Boulevard, Suite 220, Woodland Hills, CA 91364
>
>
> On 7/25/2010 8:17 PM, Chris Messina wrote:
>
> Following on Will's comment...
>
> On Fri, Jul 23, 2010 at 2:10 PM, Nathan Hazout <nathan.h at makemeheal.com>wrote:
>
>>  I'm an end-user following this thread from the outside.
>> Why are you guys forking the project? Are those going to merge back
>> together?
>> It all looks very confusing from the outside all those forks, at the end
>> we all want one good active project.
>>
>> Then again, maybe I misunderstand the "fork" concept.
>>
>
>  We're not forking insomuch as trying to find a more sustainable context
> to develop the libraries. Now that openidenabled.com is no longer really
> independent, we'd like to move development to GitHub.
>
>
>>
>> The github project page looks dead.
>>
>
>  Not really — it just needs to be resuscitated! ;)
>
>
>>  I mentioned it before I think, but it'd be really nice if we could have
>> an online documentation for this project (I'm especially interested in the
>> "provider" aspect).
>>
>
>  Agreed. if you want to take a shot at the first go at some docs, I bet
> that'd help get other people motivated to act.
>
>
>>  Every time I try to understand, I end up hitting my head against the wall
>> ...
>>
>
>  Please post specific questions here as you have them so we can document
> answers to your questions! You're likely not alone!
>
>  Chris
>
>
>>
>> Just a thought.
>> Thanks!
>>
>> Best Regards,
>> Nathan Hazout
>> Makemeheal.com
>>
>> 818-883-3300 (ext 108)
>> 20750 Ventura Boulevard, Suite 220, Woodland Hills, CA 91364
>>
>>
>> On 7/23/2010 10:34 AM, Jon Spriggs wrote:
>>
>> In that case, can I put these up for consideration:
>>
>>
>> http://github.com/JonTheNiceGuy/php-openid/commit/c78da981c1bb7d1d80f098245c8dd43a9d126ac0
>>
>> This resolves the "Bad Signature" not being cleared issue.
>>
>> And
>> http://github.com/JonTheNiceGuy/php-openid/commit/f0a7a3aece56a72695686d19655edde5f7dc9901
>>
>> This resolves a PHP warning about an empty variable which is attempted to
>> be handled as an array when parsing policies in the PAPE library.
>>
>> I'm on my phone right now, so I can't supply the exact patch files, but
>> I'm happy to provide it if the links aren't enough?
>>
>> --
>> Jon "TheNiceGuy" Spriggs
>>
>> On 23 Jul 2010 17:48, "Will Norris" <will at willnorris.com> wrote:
>>
>> sounds good to me.
>>
>>
>>
>> On Fri, Jul 23, 2010 at 9:31 AM, Chris Messina <chris.messina at gmail.com>
>> wrote:
>> >
>> > I like David's...
>>
>> _______________________________________________
>> Code mailing list
>> Code at lists.openid.net
>> http://lists.openid.net/mailman/listinfo/openid-code
>>
>>
>> _______________________________________________
>> Code mailing listCode at lists.openid.nethttp://lists.openid.net/mailman/listinfo/openid-code
>>
>>
>> _______________________________________________
>> Code mailing list
>> Code at lists.openid.net
>> http://lists.openid.net/mailman/listinfo/openid-code
>>
>>
>
>
> --
> Chris Messina
> Open Web Advocate, Google
>
> Personal: http://factoryjoe.com
> Follow me on Buzz: http://buzz.google.com/chrismessina
> ...or Twitter: http://twitter.com/chrismessina
>
> This email is:   [ ] shareable    [X] ask first   [ ] private
>
>
> _______________________________________________
> Code mailing list
> Code at lists.openid.net
> http://lists.openid.net/mailman/listinfo/openid-code
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openid.net/pipermail/openid-code/attachments/20100728/ce0c945c/attachment.html>