[Code] GitHub Pull Requests for php-openid

[Will Norris]

On Fri, Jul 23, 2010 at 11:10 AM, Nathan Hazout <nathan.h at makemeheal.com>wrote:

>  I'm an end-user following this thread from the outside.
> Why are you guys forking the project? Are those going to merge back
> together?
> It all looks very confusing from the outside all those forks, at the end we
> all want one good active project.
>
> Then again, maybe I misunderstand the "fork" concept.
>

yeah, this is very common with git.  You fork a repository (more accurately,
you "clone" it), and make your changes in your own copy.  Then the project
maintainers merge changes back upstream.



>
> The github project page looks dead.
> I mentioned it before I think, but it'd be really nice if we could have an
> online documentation for this project (I'm especially interested in the
> "provider" aspect).
> Every time I try to understand, I end up hitting my head against the wall
> ...
>
> Just a thought.
> Thanks!
>
> Best Regards,
> Nathan Hazout
> Makemeheal.com
>
> 818-883-3300 (ext 108)
> 20750 Ventura Boulevard, Suite 220, Woodland Hills, CA 91364
>
>
> On 7/23/2010 10:34 AM, Jon Spriggs wrote:
>
> In that case, can I put these up for consideration:
>
>
> http://github.com/JonTheNiceGuy/php-openid/commit/c78da981c1bb7d1d80f098245c8dd43a9d126ac0
>
> This resolves the "Bad Signature" not being cleared issue.
>
> And
> http://github.com/JonTheNiceGuy/php-openid/commit/f0a7a3aece56a72695686d19655edde5f7dc9901
>
> This resolves a PHP warning about an empty variable which is attempted to
> be handled as an array when parsing policies in the PAPE library.
>
> I'm on my phone right now, so I can't supply the exact patch files, but I'm
> happy to provide it if the links aren't enough?
>
> --
> Jon "TheNiceGuy" Spriggs
>
> On 23 Jul 2010 17:48, "Will Norris" <will at willnorris.com> wrote:
>
> sounds good to me.
>
>
>
> On Fri, Jul 23, 2010 at 9:31 AM, Chris Messina <chris.messina at gmail.com>
> wrote:
> >
> > I like David's...
>
> _______________________________________________
> Code mailing list
> Code at lists.openid.net
> http://lists.openid.net/mailman/listinfo/openid-code
>
>
> _______________________________________________
> Code mailing listCode at lists.openid.nethttp://lists.openid.net/mailman/listinfo/openid-code
>
>
> _______________________________________________
> Code mailing list
> Code at lists.openid.net
> http://lists.openid.net/mailman/listinfo/openid-code
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openid.net/pipermail/openid-code/attachments/20100723/fe67d2ba/attachment.html>