[Code] GitHub Pull Requests for php-openid

[Will Norris]

sounds good to me.

On Fri, Jul 23, 2010 at 9:31 AM, Chris Messina <chris.messina at gmail.com>wrote:

> I like David's suggestion to have the patch reviewed on the list. With
> sufficient +1's (where deficient should be defined flexibly), the
> patch should be accepted.
>
> Transparency is important, but so is getting momentum behind cleaning
> up the libraries! (which was a prime motivator for moving to GitHub).
>
> Chris
>
> On Friday, July 23, 2010, David Recordon <recordond at gmail.com> wrote:
> > Which is why I'm thinking that sending the patch to this list will give a
> variety of people the ability to review it. :)
> >
> > On Fri, Jul 23, 2010 at 9:26 AM, Will Norris <will at willnorris.com>
> wrote:
> > actually doing a standard fork + pull request in github will work fine.
>  I think when you do the pull request you can specify who you want it to be
> sent to.
> >
> > We have been generally unresponsive to these in the past, but for me that
> has primarily been due to a lack of leadership on the libraries.  By that I
> mean, no one has really taken ownership of any of the libraries since we
> moved them into github.  JanRain has continued to do minor patches, which is
> great.  And I've been in the process of cleaning up the unit tests for the
> PHP library, and beginning to write a contributor's guide.  But that only
> answers the technical questions of what you need to do in order to submit a
> patch.  I still don't know who the right people are to actually decide what
> gets committed.  As much as I'd like to, I can't commit to taking on this
> role at this time.  And even then, I'd only be comfortable doing it for PHP.
>  I don't know who would take the lead on Python or Ruby.
> >
> >
> >
> > Perhaps I'm over thinking it, I don't know.
> > -will
> >
> > On Thu, Jul 22, 2010 at 10:41 PM, David Recordon <recordond at gmail.com>
> wrote:
> > Hey Jon, as there isn't really a lot of active development, the best
> might be to attach the patches to this thread. I'm cc'ing both Will and Luke
> who have hacked on the library in the past. Thanks again for helping make it
> better!
> >
> >
> >
> >
> > --David
> >
> > On Thu, Jul 22, 2010 at 12:24 AM, Jon Spriggs <jon at spriggs.org.uk>
> wrote:
> >
> > Hi everyone.
> >
> > I've been going over my error logs, and have found a couple of PHP
> > warnings and errors when acting as a consumer in the OpenID PHP
> > library. I'd like to request that these updates be pulled into the
> > tree, but I don't know who to notify when I've made some tweaks. Would
> > it be possible to make the workflow clear, so that drive-by
> > contributors like myself can make patches?
> >
> > All the best,
> > --
> > Jon "The Nice Guy" Spriggs
> > _______________________________________________
> > Code mailing list
> > Code at lists.openid.net
> > http://lists.openid.net/mailman/listinfo/openid-code
> >
> >
> >
> >
> >
> >
> >
>
> --
> Chris Messina
> Open Web Advocate, Google
>
> Personal: http://factoryjoe.com
> Follow me on Buzz: http://buzz.google.com/chrismessina
> ...or Twitter: http://twitter.com/chrismessina
>
> This email is:   [ ] shareable    [X] ask first   [ ] private
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openid.net/pipermail/openid-code/attachments/20100723/fd5f5fd8/attachment-0001.html>