<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
That's not private_key_jwt anymore, that's client_secret_jwt, which
is a different value. We probably want to have this be more
explicitly called out where these values are defined.<br>
<br>
-- Justin<br>
<br>
<br>
<div class="moz-cite-prefix">On 02/06/2013 01:54 PM, Mike Jones
wrote:<br>
</div>
<blockquote
cite="mid:4E1F6AAD24975D4BA5B168042967394367417D25@TK5EX14MBXC284.redmond.corp.microsoft.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 14 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
margin-top:7.5pt;
margin-right:0in;
margin-bottom:0in;
margin-left:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
tt
{mso-style-priority:99;
font-family:"Courier New";}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:1102216898;
mso-list-template-ids:949136874;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi
Brian,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">There’s
one part of your comments that I didn’t know how to
address. Per the comment in the issue:<o:p></o:p></span></p>
<p style="margin-left:0in;text-indent:-.25in;mso-list:l0 level1
lfo1"><!--[if !supportLists]--><span
style="font-size:10.5pt;font-family:"Arial","sans-serif";color:#333333"
lang="EN"><span style="mso-list:Ignore">1.<span
style="font:7.0pt "Times New Roman"">
</span></span></span><!--[endif]--><span
style="font-size:10.5pt;font-family:"Arial","sans-serif";color:#333333"
lang="EN">You wrote:<o:p></o:p></span></p>
<p><span
style="font-size:10.5pt;font-family:"Arial","sans-serif";color:#333333"
lang="EN">2.2.1. Client Register Operation Response<o:p></o:p></span></p>
<p><span
style="font-size:10.5pt;font-family:"Arial","sans-serif";color:#333333"
lang="EN">says that "[client_secret] is not required for
clients selecting a token_endpoint_auth_method of
private_key_jwt" but what if they've selected HS256 (or
other HSxxx) for request_object_signing_alg or any of the <em><span
style="font-family:"Arial","sans-serif"">signed</span></em>
or
<em><span
style="font-family:"Arial","sans-serif"">singing</span></em>
parameters?<o:p></o:p></span></p>
<p><span
style="font-size:10.5pt;font-family:"Arial","sans-serif";color:#333333"
lang="EN">Do you have a suggested text change in response to
this issue?<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
Thanks,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
-- Mike<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
Mike Jones
<br>
<b>Sent:</b> Monday, January 28, 2013 12:21 PM<br>
<b>To:</b> Brian Campbell;
<a class="moz-txt-link-rfc2396E" href="mailto:openid-specs-ab@lists.openid.net"><openid-specs-ab@lists.openid.net></a><br>
<b>Subject:</b> RE: [Openid-specs-ab] Comments on
Registration (-14) Release Candidate D<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I’ve
created
<a moz-do-not-send="true"
href="http://hg.openid.net/connect/issue/727/registration-brian-campbells-review">http://hg.openid.net/connect/issue/727/registration-brian-campbells-review</a>
to track these review comments.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">
-- Mike<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">
<a class="moz-txt-link-abbreviated" href="mailto:openid-specs-ab-bounces@lists.openid.net">openid-specs-ab-bounces@lists.openid.net</a>
[<a class="moz-txt-link-freetext" href="mailto:openid-specs-ab-bounces@lists.openid.net">mailto:openid-specs-ab-bounces@lists.openid.net</a>]
<b>On Behalf Of </b>Brian Campbell<br>
<b>Sent:</b> Thursday, January 24, 2013 3:48 PM<br>
<b>To:</b> <a class="moz-txt-link-rfc2396E" href="mailto:openid-specs-ab@lists.openid.net"><openid-specs-ab@lists.openid.net></a><br>
<b>Subject:</b> [Openid-specs-ab] Comments on Registration
(-14) Release Candidate D<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Some
comments/questions on <a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html">
http://openid.net/specs/openid-connect-registration-1_0-14.html</a>
follow:<br>
<br>
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#ClientRegistration">http://openid.net/specs/openid-connect-registration-1_0-14.html#ClientRegistration</a><br>
2.1. Client Registration and Client Update Request<br>
<br>
The definition of access_token and the text near the bottom
about registration_access_token seem to suggest that the
(registration) access token need only be sent on client_update
requests. But surly it's also needed for rotate_secret?
<br>
<br>
Changing from requiring client id and secret on client_update
(and I assume rotate_secret) to needed the registration access
token suggests that (short of some additional work) clients
provisioned by some other means than this registration
endpoint cannot update themselves or rotate their secret via
the registration endpoint. I guess that could be a feature or
a bug (or just meh) depending on how you look at it. But it
just occurred to me and the change is relatively recent so I
thought I'd mention it.<br>
<br>
Honestly, it feels pretty awkward that the nature of the
access token and if it's required or not differs based on the
value of the operation parameter. It can work but means that
the code that's doing the authn/z will need to examine the
operation parameter in the request body in order to know what
to do and the content of the token and how it's processed
might be very different based on the operation. Anyway, I'm
not necessarily objecting to it but still feel compelled to
mention that it leaves kind of a bad taste.<br>
<br>
jwk_url and x509_url say they are used for "signing Token
Endpoint Requests" but there's nothing specified anywhere
about signing Token Endpoint Requests, is there? Is it
intended to mean signing the jwt when authenticating to the
token endpoint using the private_key_jwt method?<br>
<br>
All the jwk and x509 basically say that if both jwk and x509
are registered then. "the keys contained in both formats
SHOULD be the same" but Messages 4.2
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-messages-1_0-15.html#sigenc.key">http://openid.net/specs/openid-connect-messages-1_0-15.html#sigenc.key</a>
has a MUST. Shouldn't these be consistent?<br>
<br>
Issues 703 and 704 likely will impact the key parameters too.<br>
<br>
A number of places say "The valid values are listed in Section
3.1 of <a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#JWA">JWA</a>
[JWA]" with respect to signing. But is "none" an
acceptable/reasonalbe value for any or all of these?
<br>
<br>
<br>
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#ClientRegisterResponse">http://openid.net/specs/openid-connect-registration-1_0-14.html#ClientRegisterResponse</a><br>
2.2.1. Client Register Operation Response<br>
<br>
says that "[client_secret] is not required for clients
selecting a token_endpoint_auth_method of private_key_jwt" but
what if they've selected HS256 (or other HSxxx) for
request_object_signing_alg or any of the *signed* or *singing*
parameters?
<br>
<br>
This section and 2.2.3 have "Additionally, the server MUST
include all registered metadata about a client as described in
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#ClientRegistration">Section 2.1</a>,
including any fields that the server has provisioned on the
client's behalf." What is the expected behavior for default
values from 2.1 (that very well might not be stored anywhere).<br>
<br>
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#ErrorResponse">http://openid.net/specs/openid-connect-registration-1_0-14.html#ErrorResponse</a><br>
2.3. Client Registration Error Response<br>
<br>
I don't think invalid_client_id or invalid_client_secret are
valid anymore?<br>
<br>
<br>
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#Security">http://openid.net/specs/openid-connect-registration-1_0-14.html#Security</a><br>
5. Security Considerations<br>
"Requests to the Registration Endpoint for <tt><span
style="font-size:10.0pt">client_update</span></tt> MUST
have some rate limiting on failures to prevent the Client
secret from being disclosed though repeated access attempts."
Which is true, I suppose, but no longer applies to the client
secret but rather to the registration access token. Also
doesn't it apply to rotate_secret as well?<br>
<br>
<br>
<a moz-do-not-send="true"
href="http://openid.net/specs/openid-connect-registration-1_0-14.html#Acknowledgements">http://openid.net/specs/openid-connect-registration-1_0-14.html#Acknowledgements</a><br>
Appendix A. Acknowledgements<br>
<br>
Is empty. What does it take to get on there? ;) I'm sure I'm
not the only one either...<br>
<br>
<br>
Thanks,<br>
Brian<br>
<br>
<br>
P.S. I'll try and look at the other RC docs in the next few
days but it's very time consuming and not the only thing on my
(or anyone's I'm sure) plate. I just happened to be trying to
update some of my (limited) registration code today so it was
right in front of me.<br>
<br>
<br>
<o:p></o:p></p>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
Openid-specs-ab mailing list
<a class="moz-txt-link-abbreviated" href="mailto:Openid-specs-ab@lists.openid.net">Openid-specs-ab@lists.openid.net</a>
<a class="moz-txt-link-freetext" href="http://lists.openid.net/mailman/listinfo/openid-specs-ab">http://lists.openid.net/mailman/listinfo/openid-specs-ab</a>
</pre>
</blockquote>
<br>
</body>
</html>